Skip to content

Comments

[action] [PR:21143] configlet/test_add_rack.py Add comparison ignore for extra entries added by generic patcher#1028

Merged
mssonicbld merged 1 commit intoAzure:202503from
mssonicbld:cherry/msft-202503/21143
Feb 19, 2026
Merged

[action] [PR:21143] configlet/test_add_rack.py Add comparison ignore for extra entries added by generic patcher#1028
mssonicbld merged 1 commit intoAzure:202503from
mssonicbld:cherry/msft-202503/21143

Conversation

@mssonicbld
Copy link
Collaborator

Description of PR

Summary:
When patching the DUT to remove t0 peers, the test fails the DB comparison due to extra entries being added to APP_DB.

These entries only get added when generic patcher in SONiC (config apply-patch) is used to remove t0 from the DUT.

Ideally this should be fixed in config apply-patch code. This PR is a workaround for the issue since the extra entries are harmless and does not get used.

Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • msft_202412
  • 202505

Approach

What is the motivation for this PR?

configlet/test_add_rack.py is failing.

How did you do it?

Adding extra entries to ignore. These entries seems to be harmless and not used. However it is not understood why it is being added by config apply-patch.

Again, ideally this should be fixed in config apply-patch code. This PR is a workaround for the issue since the extra entries are harmless and does not get used.

How did you verify/test it?

Test no longer fails

Any platform specific information?

Broadcom platform is used for testing.

Supported testbed topology if it's a new test case?

Documentation

…ded by generic patcher

<!--
Please make sure you've read and understood our contributing guidelines;
https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md

Please provide following information to help code review process a bit easier:
-->
### Description of PR
<!--
- Please include a summary of the change and which issue is fixed.
- Please also include relevant motivation and context. Where should reviewer start? background context?
- List any dependencies that are required for this change.
-->

Summary:
When patching the DUT to remove t0 peers, the test fails the DB comparison due to extra entries being added to APP_DB.

These entries only get added when generic patcher in SONiC (`config apply-patch`) is used to remove t0 from the DUT.

Ideally this should be fixed in `config apply-patch` code. This PR is a workaround for the issue since the extra entries are harmless and does not get used.

Fixes # (issue)

### Type of change

<!--
- Fill x for your type of change.
- e.g.
- [x] Bug fix
-->

- [ ] Bug fix
- [ ] Testbed and Framework(new/improvement)
- [ ] New Test case
    - [ ] Skipped for non-supported platforms
- [ ] Test case improvement

### Back port request
- [ ] 202205
- [ ] 202305
- [ ] 202311
- [ ] 202405
- [ ] 202411
- [x] msft_202412
- [x] 202505

### Approach
#### What is the motivation for this PR?
`configlet/test_add_rack.py` is failing.

#### How did you do it?
Adding extra entries to ignore. These entries seems to be harmless and not used. However it is not understood why it is being added by `config apply-patch`.

Again, ideally this should be fixed in `config apply-patch` code. This PR is a workaround for the issue since the extra entries are harmless and does not get used.

#### How did you verify/test it?
Test no longer fails

#### Any platform specific information?
Broadcom platform is used for testing.

#### Supported testbed topology if it's a new test case?

### Documentation
<!--
(If it's a new feature, new test case)
Did you update documentation/Wiki relevant to your implementation?
Link to the wiki page?
-->
@mssonicbld
Copy link
Collaborator Author

Original PR: sonic-net/sonic-mgmt#21143

@mssonicbld
Copy link
Collaborator Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@mssonicbld mssonicbld merged commit ffa771f into Azure:202503 Feb 19, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant